From: Federico Mena Quintero <federico@gnome.org>
Date: Tue, 3 Dec 2019 01:57:08 +0000 (-0600)
Subject: st: Remove broken parsing of @media rules
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~345
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=73776508b30059d5a71ec3dcfe51e23fc1137dd1;p=gnome-shell.git

st: Remove broken parsing of @media rules

This code didn't even pay attention to the
cur_stmt->kind.media_rule->media_list, and unconditonally considered
each statement in the ->ruleset to be of kind ruleset.  That seems
broken.

(The theme doesn't use any @media queries, and they are unsupported
anyway.)

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1979
---

diff --git a/src/st/st-theme.c b/src/st/st-theme.c
index 00a2c8fb7..0d2d2eeac 100644
--- a/src/st/st-theme.c
+++ b/src/st/st-theme.c
@@ -858,16 +858,6 @@ add_matched_properties (StTheme      *a_this,
             }
           break;
 
-        case AT_MEDIA_RULE_STMT:
-          if (cur_stmt->kind.media_rule
-              && cur_stmt->kind.media_rule->rulesets
-              && cur_stmt->kind.media_rule->rulesets->kind.ruleset
-              && cur_stmt->kind.media_rule->rulesets->kind.ruleset->sel_list)
-            {
-              sel_list = cur_stmt->kind.media_rule->rulesets->kind.ruleset->sel_list;
-            }
-          break;
-
         case AT_IMPORT_RULE_STMT:
           {
             CRAtImportRule *import_rule = cur_stmt->kind.import_rule;
@@ -908,6 +898,7 @@ add_matched_properties (StTheme      *a_this,
               }
           }
           break;
+        case AT_MEDIA_RULE_STMT:
         case AT_RULE_STMT:
         case AT_PAGE_RULE_STMT:
         case AT_CHARSET_RULE_STMT: